Skip to content

Update wrapAll.xml #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

AurelioDeRosa
Copy link
Member

Added missing documentation of the possibility to pass a function (added since jQuery 1.4)

Added missing documentation of the possibility to pass a function (added since jQuery 1.4)
<signature>
<added>1.4</added>
<argument name="function" type="Function">
<desc>A callback function which generates a structure to wrap around the matched elements. Receives the index position of the element in the set as an argument. Within the function, <code>this</code> refers to the current element in the set.</desc>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd prefer, "A function that returns a structure…" so it's consistent with other methods such as .after() http://api.jquery.com/after/#after-function
Otherwise, looks great!

@kswedberg
Copy link
Member

good catch.

@AurelioDeRosa
Copy link
Member Author

Hello @kswedberg, I've updated the PR as you suggested.

@kswedberg
Copy link
Member

awesome. thanks!

@kswedberg kswedberg closed this in a1ddea9 Jul 7, 2014
@AurelioDeRosa
Copy link
Member Author

You're welcome @kswedberg !

@AurelioDeRosa AurelioDeRosa deleted the patch-2 branch July 7, 2014 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants